Fixes #983 - Make sure code is correctly formatted before publishing #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a "prepublishOnly" task that errors out if we try to publish code that isn't formatted with Prettier. Also runs the tests for obvious reasons. Once we have linting back up and running we can fail even faster with respect to formatting and warn or error at lint-time. This commit includes a fix for one incorrectly formatted file. There are also a couple of others that need re-formatting: - scripts/build/gulp/tasks/build.js - scripts/build/gulp/tasks/css.js but I am leaving those so as to avoid an unnecessary conflict with #982.
julien
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "prepublishOnly" task that errors out if we try to publish code that isn't formatted with Prettier. Also runs the tests for obvious reasons.
Once we have linting back up and running we can fail even faster with respect to formatting and warn or error at lint-time.
This commit includes a fix for one incorrectly formatted file. There are also a couple of others that need re-formatting:
but I am leaving those so as to avoid an unnecessary conflict with #982.