Remove require-dir dependency #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency doesn't do much for us: removing it shows that we can get by without it (note how we used four lines invoking the package before this commit, and when we remove the package we can get an equivalent outcome with four lines, leaving the total count unchanged). In any case, the real motivation here is that when we move to Gulp v4 (see #980), the pattern is to refer to tasks using function references rather than strings, which means we'd have to manually import the "build" tasks additionally anyway. Reducing our dependency footprint is just a bonus. Test plan: `npm run build` and see that everything still works.
julien
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency doesn't do much for us: removing it shows that we can get by without it (note how we used four lines invoking the package before this commit, and when we remove the package we can get an equivalent outcome with four lines, leaving the total count unchanged).
In any case, the real motivation here is that when we move to Gulp v4 (see #980), the pattern is to refer to tasks using function references rather than strings, which means we'd have to manually import the "build" tasks additionally anyway. Reducing our dependency footprint is just a bonus.
Test plan:
npm run buildand see that everything still works.