Remove unnecessary demo app templating #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only difference between the prod build and dev build is that the former uses the minified JS and CSS bundles. In practice, the "main" entry point in our package.json points at the non-minified build, so it's appropriate that we use the same build in the demo. Motivation: this simplifies the build and removes a dependency, which will make it easier to move to Gulp v4. Test plan: `npm run dev` and `npm run start` and confirm demo works.
|
Just started reviewing :) |
Sent from 
julien
approved these changes
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference between the prod build and dev build is that the former uses the minified JS and CSS bundles. In practice, the "main" entry point in our package.json points at the non-minified build, so it's appropriate that we use the same build in the demo.
Motivation: this simplifies the build and removes a dependency, which will make it easier to move to Gulp v4.
Test plan:
npm run devandnpm run startand confirm demo works.