Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused font related resources and tasks #977

Merged
merged 5 commits into from
Jan 23, 2019

Conversation

julien
Copy link
Contributor

@julien julien commented Jan 23, 2019

No description provided.

@julien julien requested a review from wincent January 23, 2019 11:32
Copy link
Contributor

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can npm remove gulp-icon-font as well, right?

@@ -19,7 +19,6 @@ function errorHandler(error) {

gulp.task('build-css', function(callback) {
runSequence(
'generate-fonts',
'sass2css',
'join-css',
'clean-fonts',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of clean-fonts as well?

Suggested change
'clean-fonts',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch

@julien
Copy link
Contributor Author

julien commented Jan 23, 2019

@wincent yes, we might as well get rid of that too. Thanks!

@wincent wincent merged commit 390f6bb into 2.x-develop Jan 23, 2019
@julien julien deleted the feature/cleanup_fonts branch January 24, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants