Update mocha as recommended by npm audit
#975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It passed!, but now there is a merge conflict. 😂 This is actually good news though, because it means the build is failing due to flakiness and not due to a fundamental incompatibility with Mocha. That means I can keep rerunning it until I see it pass, knowing that it's not a total waste of time. (Could also just rebase and merge, TBH, but I think I'll wait to see it green again... I think...) |
Before:
found 8 vulnerabilities (3 low, 4 high, 1 critical) in 17615 scanned packages
After:
found 6 vulnerabilities (2 low, 4 high) in 17609 scanned packages
`npm run test` still green after this change.
|
Well, Travis isn't even trying to run this, maybe because it saw that it passed already? Going to pull the trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
npm run dev && npm run teststill green after this change.Originally tried in #958, #965, #967, #972. Fifth time lucky, as they say!