Fixes #969 - Don't commit the "dist" contents to the Git repo #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Not for actually merging, just for discussion; cc @julien) |
Closed
We have an .npmignore file that excludes some junk from any published package, but if you look at everything we included in the last release: https://gist.github.com/wincent/35e0d4d3609ab6595cee1eb2768f7ae0 you see quite a few things that shouldn't be in there, like test files and such. There is even a yarn.lock in there.
julien
approved these changes
Jan 22, 2019
julien
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting this here for discussion of the merits of committing/not-committing this stuff to the repo. If we decide to do this, I would want to potentially make some other changes on top of this.