Apply some minor clean-up while investigating slow build speeds #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable holds a list of tasks so it should have a plural name. Noticed while doing some exploration for the related ticket: https://issues.liferay.com/browse/IFI-406
I notice that the `runSequence` callback is firing pretty much immediately even before all the tasks have finished running, which means that somewhere in the task graph something is not correctly signalling its completion. I haven't found the culprit yet, but in looking for it I noticed these places where we can clean things up by returning a promise instead of passing around a callback, which makes things more readable.
|
Just started reviewing :) |
Sent from 
julien
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the commit messages, this PR just applies a little clean-up noted while doing some initial investigation for IFI-406.