Add extra buttons from liferay-portal #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
reviewed
Jan 17, 2019
wincent
reviewed
Jan 17, 2019
| var instance = this; | ||
|
|
||
| var focusAltEl = function () { | ||
| ReactDOM.findDOMNode(instance.refs.refAltInput).focus(); |
There was a problem hiding this comment.
Use of findDOMNode is deprecated (or will be soon) — the suggestion is to use refs instead.
| ) | ||
| } else { | ||
| active = false; | ||
| } |
There was a problem hiding this comment.
I wonder if all this would read better with every()? Something like:
return styleConfig.attributes.class.split(' ').every(
className => elementPath.lastElement.hasClass(className)
);
added 10 commits
January 17, 2019 17:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jbalsas and @wincent,
This add the extra buttons that we had in
liferay-portal.There are probably still a few things to clean up and maybe discuss for this to be totally finished but I thought I'd send you the PR so we can start the conversation.
On the top of my head these are the main things that need to be finished or at least that you should be aware of.
button-camera-image.jsxcomponent has been fixed, I discovered it was no longer working in Chrome or Safari while working on this task.button-link-browse.jsxcomponent was usingAUI(I removed that), we talked about either emitting an event or allowing passing a callback, it might be a good time to talk about it together and decide what which solution seems "right".embedurlplugin work outside the portal, but @jbalsas and I already agreed that we would have a look at it.ae-svg-iconcss class with @marcoscv-work but please let us know what you think@wincent if you see anything "bad" or crazy don't hesitate your feedback is more than welcome.
Thanks!