Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #906 | Implement feature sets #930

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Conversation

julien
Copy link
Contributor

@julien julien commented Nov 28, 2018

No description provided.

@julien
Copy link
Contributor Author

julien commented Nov 30, 2018

Adding this as a note for later:

  • Apparently Saucelabs results are random:
    sometimes restarting the build (with no changes) marks the build as successful,
    sometimes it marks the build as failed.

  • We should probably remove 'colors' from the karma configuration for saucelabs as it makes it impossible to read ... the logs are full of escape codes (�[34m�[ and similiar)

@jbalsas
Copy link
Contributor

jbalsas commented Dec 7, 2018

Hey @julien, can we split this into at least 2 commits:

  • Update CKEditor
  • Implement Feature Sets

Thanks! ;)

@julien julien force-pushed the feature/feature_sets branch from 0695087 to 1ab0230 Compare December 7, 2018 10:29
@jbalsas jbalsas merged commit c95d8dc into develop Dec 7, 2018
@julien julien deleted the feature/feature_sets branch January 24, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants