Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autolink test #907

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix autolink test #907

merged 1 commit into from
Nov 15, 2018

Conversation

julien
Copy link
Contributor

@julien julien commented Nov 15, 2018

No description provided.

@julien julien changed the title [DON'T MERGE] Try to fix autolink test Fix autolink test Nov 15, 2018
@julien
Copy link
Contributor Author

julien commented Nov 15, 2018

@jbalsas could you please have a look at this and share your thoughts?
I'm basically trying to fix the test that recently started failing in saucelabs, but since nothing had been changed for a long time in this file, I'd like to have a second opinion.

Thanks!

@julien julien requested a review from jbalsas November 15, 2018 16:23
@jbalsas
Copy link
Contributor

jbalsas commented Nov 15, 2018

Hey @julien, in which browser was this failing? The test is basically positioning the cursor after the link and simulating an ENTER press... sometimes, bender has trouble positioning the cursor, and this may change from one browser version to another...

I'd say this feels okay. We should run some manual tests on this to make sure, but I'll merge for now.

@jbalsas jbalsas merged commit d97896d into liferay:master Nov 15, 2018
@julien
Copy link
Contributor Author

julien commented Nov 16, 2018

@jbalsas,

After updating the saucelabs config, this test was failing on saucelabs for these browsers+os'es combinations:

Chrome 70.0.3538 on Windows 10
Chrome 70.0.3538 on OS X 10.11 (El Capitan)
Chrome 70.0.3538 on macOS 10.12 (Sierra)

The strange thing though, is that they're failing neither on macOS 10.13 (High Sierra) nor on Linux (I'm not sure about the distro used) for the same browser.

Even stranger, locally (even though this shouldn't be relevant) I have the exact same Chrome version on OS X 10.11 and it wasn't failing (neither before or after the change ... )

We also ran some manual tests with @antonio-ortega and the "rendered" HTML doesn't look exactly like what's expected in the tests, i.e.

Instead of this:

<p>link <a href="http://www.liferay.com">www.liferay.com</a></p><p>text</p>

What I see after typing:

link www.liferay.com text

Looks like this:

<p>link <a data-cke-saved-href="http://www.liferay.com" href="http://www.liferay.com">www.liferay.com</a>&nbsp;test</p>

I understand that these tests are "difficult" to implement especially in a cross-browser way but I agree that we should do something about this.

Anyway thanks again for your help and feedback.

@julien julien deleted the test_autolink branch December 19, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants