Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-84123 #872

Merged
merged 1 commit into from
Aug 14, 2018
Merged

[TS] LPS-84123 #872

merged 1 commit into from
Aug 14, 2018

Conversation

arthurchan35
Copy link
Contributor

@arthurchan35
Copy link
Contributor Author

@jbalsas

@arthurchan35
Copy link
Contributor Author

@antoniopol06 @ambrinchaudhary @diegonvs @ipeychev
Hi guys, I heard Chema is OOTO right now, can someone help review this pull request? It's a customer issue, so we want to have it complete ASAP.

Thanks

@diegonvs
Copy link
Contributor

diegonvs commented Aug 8, 2018

Hey @arthurchan35, to maintain a better description for non-liferay workers, could you improve the pull request description?

@diegonvs
Copy link
Contributor

diegonvs commented Aug 8, 2018

I'm taking a look right now 😄

@diegonvs
Copy link
Contributor

diegonvs commented Aug 8, 2018

LGTM! What do you think @matuzalemsteles?

@julien
Copy link
Contributor

julien commented Aug 14, 2018

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit 43bf4ee into liferay:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants