Adjust toolbar placement on right side to prevent overflow

[fortunatomaldonado]

Issue

The toolbar may overflow on the right side of the screen if the user has a smaller screen or resizes the browser. This will prevent users from seeing toolbar options.

Reproduce

Example of issue can be found here: #866 (comment)

Solution

By checking if the placement of the left is going to be greater than the document's body offset subtracted by the toolbar width, we can prevent any overflow.

[jbalsas]

Hey @fortunatomaldonado, thanks for sending this over! Based on the screenshots, it looks like we need some adjustment.

@julien is currently on vacation. He'll be back next week. If that's okay, I'd like to wait so he can take a look here.

Thanks!

[fortunatomaldonado]

Hello @jbalsas,

Of course, that is not a problem. Thank you for letting me know.

[fortunatomaldonado]

Hello @julien,

When you have a chance, can you take a look at this?

Thank you.

[julien]

Just started reviewing :)

Sent from GH.

[julien]

Hi @fortunatomaldonado,

Sorry for the delay; I just tested in master and everything seems working fine as far as I'm concerned

But in the alloy-editor demo however it seems it's not working exactly the same way

If this is an acceptable behaviour, I'm ok with the changes. Tell me what you think when you can.

Thanks

[duracell80]

Hey guys thanks for working on these issues they will make a big positive improvement for users. Has there ever been a suggestion to move away from the cursor placement of this bar?

It seems a lot of issues would just go away if the bar was afixed top left of the text area and fixed in place.

[fortunatomaldonado]

Hello @julien,

Thank you for the quick review. I saw the same results in the demo as well. I believe this is due to the demo's editor being surrounded by margins unlike in master and 7.0.x. If you remove the margins from the demo it seems to work as intended. I believe this will still be acceptable behavior.

Thank you again for looking into this.

[julien]

Hi @fortunatomaldonado ,
I tested again without any margins applied and you're right, it's all good.
Thanks!