Resize visible #855
Merged
Resize visible #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#852
In _setUIHidden we check whether the user's interaction target is within the editor / editable area.
The issue is that dragresize dynamically generates the drag handles outside of the editable div and making
editable.contains(targetNode)false and thus we're treating resizing as though we're outside the UI.Solution
We modify the _setUIHidden check to also test whether we're resizing an image. We do this by checking whether the target is within the div with id "ckimgrsz".
Test
Chrome and FireFox.