Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 3rd party react components #780

Merged
merged 8 commits into from
Oct 19, 2017
Merged

remove 3rd party react components #780

merged 8 commits into from
Oct 19, 2017

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Oct 19, 2017

No description provided.

@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 19, 2017

Hey @ipeychev, could you double-check this before I merge?

We've done here the bare-minimum, keeping v0.14.2 as our bundled version of React and just applying the necessary changes so that the *-no-react version of AlloyEditor works when overlayed on top of a React@16 distribution.

With this, we avoid any breakage or unexpected behaviour changes. This is in a big part driven by our current build process which makes adopting newer versions of React a bit more cumbersome than expected. We plan to address this soon after we release 1.5.0 with an in-depth refactor of how modules are written and bundled so we can release a 2.0.0 bundling React16.

Please, let us know what you think. Hope that makes sense!

@ipeychev
Copy link
Contributor

👍 from me and congratulations to @vbence86 for the great job on that!

@jbalsas jbalsas merged commit d34fe1b into master Oct 19, 2017
@jbalsas jbalsas deleted the react_16_support branch November 16, 2017 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants