Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets editor property before potentially start the render phase #725

Merged
merged 2 commits into from
Apr 11, 2017

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Apr 11, 2017

This is a potential fix for #724. The code path is not yet tested because we didn't find a proper way to test the LoadLanguageResources path, if I remember correctly.

@jbalsas jbalsas requested a review from ipeychev April 11, 2017 09:15
@ipeychev
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@jbalsas
Copy link
Contributor Author

jbalsas commented Apr 11, 2017

@ipeychev, pushed changes discussed in #724

@ipeychev
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@ipeychev
Copy link
Contributor

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.

@ipeychev ipeychev merged commit 074be22 into master Apr 11, 2017
@jbalsas jbalsas deleted the AE-724 branch November 16, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants