Hash autogenerated by build-languages task

[antoniopol06]

No description provided.

[ipeychev]

@jbalsas, was that PR reviewed already by you? I don't know PoEditor, so it won't be easy for me to see if it fits its requirements.

[jbalsas]

Hey @ipeychev, I'm currently on vacation, so no, I haven't reviewed it. The only requirement is to have the strings to be translated in a json file. We also aimed to simplify this a little bit. I can review next week after I get back. El El mar, 7 mar 2017 a las 9:09, Iliyan Peychev <notifications@github.com> escribió:

…

@jbalsas <https://github.com/jbalsas>, was that PR reviewed already by you? I don't know PoEditor, so it won't be easy for me to see if it fits its requirements. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#703 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3PLrxieZFckAPCbc2p45k06DjJ-LJ1ks5rjRDRgaJpZM4MUVf6> .

[ipeychev]

Ah, okay then. Great, let's manage this PR the next week.

Thanks,

[jbalsas]

Just started reviewing :)

Sent from GH.

[jbalsas]

Hey @ipeychev, I've reviewed, merged and pushed this to keep exploring the integration. In essence, this can be summarized as:

• We have a src/ui/react/src/assets/lang/vendor/ckeditor.json file with the strings we want to grab from CKEditor
• We have src/ui/react/src/assets/lang/{locale}.json files with our custom strings translated to the desired language
• We have lib/lang/{locale.js} files with all the CKEditor lang strings out of the box

When building we hash those three sets and if it doesn't match the previous one, we proceed to update the generated language files by simply merging the translated keys in ckeditor.json and the corresponding {locale}.json.

We've also identified some edge cases in the build that we'll proceed to fix during the week.

[ipeychev]

Het @jbalsas, that's cool! My note and a small concern would be about the hash used there - it is SHA1, isn't it? SHA1 is obsolete and should be avoided. The library used in the code is able to generate hash using other algorithms too. You may think to change the algorithm to SHA256 or even use Node crypto directly.

Thanks,

[jbalsas]

Thanks for that tip, @ipeychev, we'll take a look to those!