Y position of toolbar to render it, now we consider if the content has overflow customization to calculate the proper Y value #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s overflow customization to calculate the proper Y value Fixes liferay#549
|
Just started reviewing :) |
Sent from 
|
Hey @ipeychev, could we release a new version after this gets merged? Thanks! |
|
Sure, probably this weekend. Thanks, |
|
Awesome, thanks! We'll try to squeeze one more fix in, then 😉 |
|
Thank you, pull request merged! See changes here. |
antoniopol06
pushed a commit
to antoniopol06/alloy-editor
that referenced
this pull request
Nov 14, 2016
ipeychev
pushed a commit
that referenced
this pull request
Nov 17, 2016
ipeychev
pushed a commit
that referenced
this pull request
Nov 17, 2016
azotova
pushed a commit
to azotova/alloy-editor
that referenced
this pull request
Jan 7, 2017
azotova
pushed a commit
to azotova/alloy-editor
that referenced
this pull request
Jan 7, 2017
azotova
pushed a commit
to azotova/alloy-editor
that referenced
this pull request
Jan 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.