Update lang files #382
Update lang files #382
Conversation
Fixes #AE-375
| @@ -99,22 +101,24 @@ | |||
| * @method _renderUI | |||
| */ | |||
| _renderUI: function() { | |||
| var editorUIElement = document.createElement('div'); | |||
| editorUIElement.className = 'ae-ui'; | |||
| if (!this._destroyed) { | |||
There was a problem hiding this comment.
@ipeychev, can you think of a better way of doing this?
The thing is that because we call _renderUI asynchronously on langResourcesLoaded, it might still happen that we render the UI after the destroy method has been called.
The visible result is that, even if CKEditor does not complain now, we still get issues because of the _mousedown events we attached and couldn't remove because of destructor being invoked first.
|
Just started reviewing :) |
Sent from
|
Hey Chema, I can imagine, but not with the current logic/code. We don't have mechanism for canceling the process of loading resources, so on practice there is nothing to do. We could introduce such, of course, but I don't think it is worth the efforts. The solution you suggest is the cheapest one, so let's go with it. Thanks, |
|
Thank you, pull request merged! |
Hey @ipeychev, I've updated CKEditor to 4.5.5. This should fix #375 and #381.
I'll try to keep our version in sync with CKEditor releases moving forward to avoid having unfixed issues in our branch.
Thanks!