fix: make globs work on Windows #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids this spurious error on Windows:
$ prettier --write -- '*.{js,json,md}' '{.github,scripts,src,test}/**/*.{js,jsx,md}'
[error] No matching files. Patterns tried: '*.{js,json,md}' '{.github,scripts,src,test}/**/*.{js,jsx,md}' !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
Seems that single quotes get treated literally by the shell, so you have
to use double quotes instead:
https://stackoverflow.com/a/48104731/2103996
|
Got @georgel-pop-lr to confirm that this works on Windows, and apparently, it does. 🎉 |
|
CI is green (https://travis-ci.org/liferay/alloy-editor/builds/650411315), so going to merge this. |
wincent
added a commit
to liferay/liferay-npm-tools
that referenced
this pull request
Feb 14, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
wincent
added a commit
to liferay/liferay-js-themes-toolkit
that referenced
this pull request
Feb 14, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
wincent
added a commit
to liferay/eslint-config-liferay
that referenced
this pull request
Feb 14, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
This was referenced Feb 14, 2020
wincent
added a commit
to liferay/liferay-ckeditor
that referenced
this pull request
Feb 14, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
wincent
added a commit
to liferay/liferay-frontend-guidelines
that referenced
this pull request
Feb 14, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
bryceosterhaus
pushed a commit
to bryceosterhaus/clay
that referenced
this pull request
May 19, 2020
Analogous change to this one on the alloy-editor repo: liferay/alloy-editor#1374 Just in case anybody is ever foolhardy enough to try doing development on this repo on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids this spurious error on Windows:
Seems that single quotes get treated literally by the shell, so you have to use double quotes instead:
https://stackoverflow.com/a/48104731/2103996