Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last 4 lints in dragresize_ie11.js #1038

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Fix last 4 lints in dragresize_ie11.js #1038

merged 1 commit into from
Jan 30, 2019

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Jan 30, 2019

src/plugins/dragresize_ie11.js
  1239:7   error  Identifier 'resizer_ne' is not in camel case                                                                camelcase
  1241:7   error  Identifier 'resizer_nw' is not in camel case                                                                camelcase
  1243:7   error  Identifier 'resizer_se' is not in camel case                                                                camelcase
  1245:7   error  Identifier 'resizer_sw' is not in camel case                                                                camelcase

Test plan: npm run dev && npm run test

Related: #990

```
src/plugins/dragresize_ie11.js
  1239:7   error  Identifier 'resizer_ne' is not in camel case                                                                camelcase
  1241:7   error  Identifier 'resizer_nw' is not in camel case                                                                camelcase
  1243:7   error  Identifier 'resizer_se' is not in camel case                                                                camelcase
  1245:7   error  Identifier 'resizer_sw' is not in camel case                                                                camelcase
```

Test plan: `npm run dev && npm run test`

Related: #990
@julien
Copy link
Contributor

julien commented Jan 30, 2019

Just started reviewing :)

:octocat: Sent from GH.

@julien julien merged commit 47cead2 into liferay:2.x-develop Jan 30, 2019
@wincent wincent deleted the lint/n+26 branch January 30, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants