Fix lints in plugins/Resizer.es.js #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` 19:24 error 'box' is defined but never used no-unused-vars 71:38 error 'index' is defined but never used no-unused-vars ``` I just removed the `index` param from the `forEach` call because it is totally standard to omit it. For the `box` param, I added configuration to mark params starting with `_` as unused, because all the neighboring methods take a `box` and use it, and I wanted this one to basically say, "I know all my neighbors take a `box` and I could use it too but I don't need to". Related: #990
julien
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed the
indexparam from theforEachcall because it is totally standard to omit it.For the
boxparam, I added configuration to mark params starting with_as unused, because all the neighboring methods take aboxand use it, and I wanted this one to basically say, "I know all my neighbors take aboxand I could use it too but I don't need to".Related: #990