Cannot Remove Embed Link from Editor

[btknorr]

We are using the most basic form of AlloyEditor, no plugins or anything. Just using AlloyEditor.editable('myContentEditable'); like stated in the guide.

Everything works great until you add an embed link. Once it's there, it cannot be removed. How do you remove an embed link? If you select it, the embed link field pops up, and if you click the X, and then the checkmark, it still remains. If you select it and then hit the backspace key, the browser goes back in it's history to the previous web page. Very frustrating...please advise.

Thanks,

Brian

[btknorr]

See for yourself using the AlloyEditor demo, just add an embed link and then try to remove it :)

http://alloyeditor.com/demo

[jbalsas]

Hey @btknorr, I just verified the issue. I think it only happens if the embed content has an iframe. We have some code that forces the widget selection so it triggers a selectionChange event which seems to be causing the inner iframe to be focused making it impossible to remove.

If you're building AlloyEditor yourself, you may try commenting this line and rebuilding the editor.

We'll work on this next week to come up with a complete solution.

Thanks for letting us know about it, and sorry for the inconvenience!

[jbalsas]

On a related note, this fix in upstream CKEditor might be relevant: http://dev.ckeditor.com/ticket/14538

[ipeychev]

Hey Chema,

I was going to release this weekend ver. 1.5.1 which includes the fix for #515 (great job from @antoniopol06 and you), but in this case let's postpone it for one week and include the fix for this issue too, okay?

Thanks,

[jbalsas]

Hey Iliyan, yeah, I agree. We'll work on this next week.

BTW, I think we should be planning 1.2.1, we're currently at 1.2.0 😅

[ipeychev]

Yeah, correct, 1.2.1 of course - too many projects and I started to get confused which one is on which version :D
Btw, talking about versioning, do you know Semantic release/Commitizen? They help people to have better change logs and better versioning. Maybe it will be good idea to think for adopting them.

Thanks,

[jbalsas]

I just sent a fix proposal for this (#517), including:

• Allows for easy removal of the widgets using the keyboard
• Adds a remove button to the embed toolbar like the one when editing a link