-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-46949 Fix failing test about tabs not being localized in Frontend Data Set Sample #4739
base: master
Are you sure you want to change the base?
Conversation
CI is automatically triggering the following test suites:
|
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46949 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ⚙️ Running preflight checks... [exec] [exec] ⚙️ Checking outdated tsconfig.json files ... [exec] [exec] ⚙️ Running TypeScript checks on modified files... [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers [exec] [exec] ⚙️ Running format checks on modified files... [exec] /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts [exec] 27:64 error Expected object keys to be in natural ascending order. 'locale' should be before 'site'. sort-keys [exec] 29:2 error 'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u. @typescript-eslint/no-unused-vars [exec] 1:1 error File has format errors. (format check) [exec] [exec] ✖ 3 problems (3 errors, 0 warnings) [exec] [exec] [exec] ❌ CI checks failed. [exec] [exec] [exec] FAILURE: Build failed with an exception. [exec] [exec] * What went wrong: [exec] Execution failed for task ':packageRunCheckFormat'. [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1 [exec] [exec] * Try: [exec] > Run with --info or --debug option to get more log output. [exec] > Run with --scan to get full insights. [exec] > Get more help at https://help.gradle.org. [exec] [exec] * Exception is: [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'. [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148) [exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134) [exec] at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46) |
Jenkins Build:test-portal-source-format#7472 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-18[12:31:23] Testray Build ID: Testray Importer:publish-testray-report#27475 |
ci:test:sf |
❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46949 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ⚙️ Running preflight checks... [exec] [exec] ⚙️ Checking outdated tsconfig.json files ... [exec] [exec] ⚙️ Running TypeScript checks on modified files... [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers [exec] [exec] ⚙️ Running format checks on modified files... [exec] /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts [exec] 27:64 error Expected object keys to be in natural ascending order. 'locale' should be before 'site'. sort-keys [exec] 29:2 error 'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u. @typescript-eslint/no-unused-vars [exec] [exec] ✖ 2 problems (2 errors, 0 warnings) [exec] [exec] [exec] ❌ CI checks failed. [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. [exec] error Command failed with exit code 1. [exec] [exec] > Task :packageRunCheckFormat FAILED [exec] [exec] [exec] FAILURE: Build failed with an exception. [exec] [exec] * What went wrong: [exec] Execution failed for task ':packageRunCheckFormat'. [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1 [exec] [exec] * Try: [exec] > Run with --info or --debug option to get more log output. [exec] > Run with --scan to get full insights. [exec] > Get more help at https://help.gradle.org. [exec] [exec] * Exception is: [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'. [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148) [exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134) |
Jenkins Build:test-portal-source-format#6723 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[00:20:23] Testray Build ID: Testray Importer:publish-testray-report#26058 |
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46949 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6255 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[00:38:45] Testray Build ID: Testray Importer:publish-testray-report#7031 |
ci:test:relevant |
✔️ ci:test:stable - 24 out of 24 jobs passed❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 11 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:ci:test:relevant - 29 out of 32 jobs PASSED3 Failed Jobs:
29 Successful Jobs:For more details click here.Failures unique to this pull:Failures in common with acceptance upstream results at 1aef8c7:Test bundle downloads: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#11043 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-02-19[01:17:09] Testray Build ID: Testray Importer:publish-testray-report#24423 |
✔️ ci:test:stable - 24 out of 24 jobs passed❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 26 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: f7747cb14a86dba4def878d1ef176ff42f8f274d ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:ci:test:relevant - 30 out of 32 jobs PASSED2 Failed Jobs:
30 Successful Jobs:For more details click here.Failures unique to this pull:For upstream results, click here.Test bundle downloads: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6385 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-03-10[04:15:08] Testray Build ID: Testray Importer:publish-testray-report#36799 |
ci:test:sf |
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46949 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ⚙️ Running preflight checks... [exec] [exec] ⚙️ Checking outdated tsconfig.json files ... [exec] [exec] ⚙️ Running TypeScript checks on modified files... [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers [exec] [exec] ⚙️ Running format checks on modified files... [exec] /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/advanced.spec.ts [exec] 1:1 error File has format errors. (format check) [exec] [exec] ✖ 1 problem (1 error, 0 warnings) [exec] [exec] [exec] ❌ CI checks failed. [exec] error Command failed with exit code 1. [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. [exec] [exec] > Task :packageRunCheckFormat FAILED [exec] [exec] [exec] FAILURE: Build failed with an exception. [exec] [exec] * What went wrong: [exec] Execution failed for task ':packageRunCheckFormat'. [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1 [exec] [exec] * Try: [exec] > Run with --info or --debug option to get more log output. [exec] > Run with --scan to get full insights. [exec] > Get more help at https://help.gradle.org. [exec] [exec] * Exception is: [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'. [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148) [exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146) [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134) [exec] at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46) [exec] at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51) |
Jenkins Build:test-portal-source-format#7661 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-03-11[07:56:16] Testray Build ID: Testray Importer:publish-testray-report#27809 |
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-46949 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#3293 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4739 - 2025-03-11[08:07:10] Testray Build ID: Testray Importer:publish-testray-report#13641 |
ci:test:relevant |
✔️ ci:test:stable - 24 out of 24 jobs passed❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 4 minutesClick here for more details.This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result: ci:reevaluate:1377401_20901 Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 15191a5ee86370e85705fa470f526953c124f4e9 ci:test:stable - 24 out of 24 jobs PASSED24 Successful Jobs:ci:test:relevant - 30 out of 32 jobs PASSED2 Failed Jobs:
30 Successful Jobs:For more details click here.Failures unique to this pull:For upstream results, click here.Test bundle downloads: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#20901 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4739 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4739 - 2025-03-11[08:25:57] Testray Build ID: Testray Importer:publish-testray-report#45043 |
Hi,
In order to fix LPD-46949 the first commit is enough. That test started failing when we moved from liferay-ui:tabs to clay:navigation-bar. Since those tabs are not part of Frontend Data Set itself, it's enough to search for original name 'Classic'.
Apart from that and after talking to @dsanz , I've also moved from Poshi to Playwright the rest of tests in the second commit since they were relatively straightforward.
There are still a pair of .testcase files in the same folder we should migrate.
Thanks.