Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-46949 Fix failing test about tabs not being localized in Frontend Data Set Sample #4739

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

antonio-ortega
Copy link
Collaborator

Hi,

In order to fix LPD-46949 the first commit is enough. That test started failing when we moved from liferay-ui:tabs to clay:navigation-bar. Since those tabs are not part of Frontend Data Set itself, it's enough to search for original name 'Classic'.

Apart from that and after talking to @dsanz , I've also moved from Poshi to Playwright the rest of tests in the second commit since they were relatively straightforward.

There are still a pair of .testcase files in the same folder we should migrate.

Thanks.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: b341e4827ddac69e5d09e438ba87ce791f3ca5f1

0 out of 1jobs PASSED
For more details click here.
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts
     [exec]      27:64  error  Expected object keys to be in natural ascending order. 'locale' should be before 'site'.  sort-keys
     [exec]      29:2  error  'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]      1:1  error  File has format errors.  (format check)
     [exec]    
     [exec]    ✖ 3 problems (3 errors, 0 warnings)
     [exec]    
     [exec]    
     [exec] ❌ CI checks failed.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] > Get more help at https://help.gradle.org.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)

@liferay-continuous-integration
Copy link
Collaborator

@antonio-ortega
Copy link
Collaborator Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: 047802b8a70f3774e66813570e24dd345c4a1deb

0 out of 1jobs PASSED
For more details click here.
     [exec] > Task :packageRunCheckFormat
     [exec] yarn run v1.13.0
     [exec] \$ node-scripts check:ci
     [exec] 
     [exec] ⚙️ Running preflight checks...
     [exec] 
     [exec] ⚙️ Checking outdated tsconfig.json files ...
     [exec] 
     [exec] ⚙️ Running TypeScript checks on modified files...
     [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
     [exec] 
     [exec] ⚙️ Running format checks on modified files...
     [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/classic.spec.ts
     [exec]      27:64  error  Expected object keys to be in natural ascending order. 'locale' should be before 'site'.  sort-keys
     [exec]      29:2  error  'fdsSamplePageURL' is assigned a value but never used. Allowed unused vars must match /^_/u.  @typescript-eslint/no-unused-vars
     [exec]    
     [exec]    ✖ 2 problems (2 errors, 0 warnings)
     [exec]    
     [exec]    
     [exec] ❌ CI checks failed.
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] > Run with --info or --debug option to get more log output.
     [exec] > Run with --scan to get full insights.
     [exec] > Get more help at https://help.gradle.org.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
     [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)

@liferay-continuous-integration
Copy link
Collaborator

@antonio-ortega
Copy link
Collaborator Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Sender Branch:

Branch Name: LPD-46949
Branch GIT ID: a3399251b0c70edabca6469e7ae2fe2f7482b569

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@antonio-ortega
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 24 out of 24 jobs passed

❌ ci:test:relevant - 29 out of 32 jobs passed in 1 hour 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed

Upstream Comparison:

Branch GIT ID: 1aef8c7c1f29d044950b1c2ace31c81be0af0bed
Jenkins Build URL: EE Development Acceptance (master) - 1197 - 2025-02-18[12:37:20]

ci:test:stable - 24 out of 24 jobs PASSED
24 Successful Jobs:
    ci:test:relevant - 29 out of 32 jobs PASSED

    3 Failed Jobs:

    29 Successful Jobs:
      For more details click here.

      Failures unique to this pull:


      Failures in common with acceptance upstream results at 1aef8c7:
      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ✔️ ci:test:stable - 24 out of 24 jobs passed

      ❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 26 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: f7747cb14a86dba4def878d1ef176ff42f8f274d

      Upstream Comparison:

      Branch GIT ID: f7747cb14a86dba4def878d1ef176ff42f8f274d
      Jenkins Build URL: EE Development Acceptance (master) - 1222 - 2025-03-08[12:36:19]

      ci:test:stable - 24 out of 24 jobs PASSED
      24 Successful Jobs:
        ci:test:relevant - 30 out of 32 jobs PASSED

        2 Failed Jobs:

        30 Successful Jobs:
          For more details click here.

          Failures unique to this pull:

          For upstream results, click here.

          Test bundle downloads:

          @liferay-continuous-integration
          Copy link
          Collaborator

          @antonio-ortega
          Copy link
          Collaborator Author

          ci:test:sf

          @liferay-continuous-integration
          Copy link
          Collaborator

          ❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: 8bfebde4390709fb2b8f3ae249ba34b320385f1c

          Sender Branch:

          Branch Name: LPD-46949
          Branch GIT ID: 439766f27ce7567020a4ab5eddcca12ce75738cf

          0 out of 1jobs PASSED
          For more details click here.
               [exec] > Task :packageRunCheckFormat
               [exec] yarn run v1.13.0
               [exec] \$ node-scripts check:ci
               [exec] 
               [exec] ⚙️ Running preflight checks...
               [exec] 
               [exec] ⚙️ Checking outdated tsconfig.json files ...
               [exec] 
               [exec] ⚙️ Running TypeScript checks on modified files...
               [exec] ℹ️ A total of 12 CPUs were detected: launching tsc using 12 workers
               [exec] 
               [exec] ⚙️ Running format checks on modified files...
               [exec]    /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-web/advanced.spec.ts
               [exec]      1:1  error  File has format errors.  (format check)
               [exec]    
               [exec]    ✖ 1 problem (1 error, 0 warnings)
               [exec]    
               [exec]    
               [exec] ❌ CI checks failed.
               [exec] error Command failed with exit code 1.
               [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
               [exec] 
               [exec] > Task :packageRunCheckFormat FAILED
               [exec] 
               [exec] 
               [exec] FAILURE: Build failed with an exception.
               [exec] 
               [exec] * What went wrong:
               [exec] Execution failed for task ':packageRunCheckFormat'.
               [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
               [exec] 
               [exec] * Try:
               [exec] > Run with --info or --debug option to get more log output.
               [exec] > Run with --scan to get full insights.
               [exec] > Get more help at https://help.gradle.org.
               [exec] 
               [exec] * Exception is:
               [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
               [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148)
               [exec]   at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
               [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
               [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
               [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
               [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)

          @liferay-continuous-integration
          Copy link
          Collaborator

          @antonio-ortega
          Copy link
          Collaborator Author

          ci:test:sf

          @liferay-continuous-integration
          Copy link
          Collaborator

          ✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: 8bfebde4390709fb2b8f3ae249ba34b320385f1c

          Sender Branch:

          Branch Name: LPD-46949
          Branch GIT ID: a1626cb7ee0af0002b7d6377a544f9c7b2357ef1

          1 out of 1jobs PASSED
          1 Successful Jobs:
          For more details click here.

          @liferay-continuous-integration
          Copy link
          Collaborator

          @antonio-ortega
          Copy link
          Collaborator Author

          ci:test:relevant

          @liferay-continuous-integration
          Copy link
          Collaborator

          ✔️ ci:test:stable - 24 out of 24 jobs passed

          ❌ ci:test:relevant - 30 out of 32 jobs passed in 1 hour 4 minutes

          Click here for more details.

          This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

          ci:reevaluate:1377401_20901

          Base Branch:

          Branch Name: master
          Branch GIT ID: 8bfebde4390709fb2b8f3ae249ba34b320385f1c

          Upstream Comparison:

          Branch GIT ID: 15191a5ee86370e85705fa470f526953c124f4e9
          Jenkins Build URL: EE Development Acceptance (master) - 1225 - 2025-03-10[20:49:48]

          ci:test:stable - 24 out of 24 jobs PASSED
          24 Successful Jobs:
            ci:test:relevant - 30 out of 32 jobs PASSED

            2 Failed Jobs:

            30 Successful Jobs:
              For more details click here.

              Failures unique to this pull:

              For upstream results, click here.

              Test bundle downloads:

              @liferay-continuous-integration
              Copy link
              Collaborator

              Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
              Projects
              None yet
              Development

              Successfully merging this pull request may close these issues.

              4 participants