Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize error before sending to xray #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andyrichardson
Copy link

About

Fix #58

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 351

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 350: 0.0%
Covered Lines: 22
Relevant Lines: 22

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 351

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 350: 0.0%
Covered Lines: 22
Relevant Lines: 22

💛 - Coveralls

@mdlavin
Copy link
Member

mdlavin commented Dec 7, 2020

Would it be possible to detect errors with circular references and only serialize those? I'm not sure about the impact of loosing the original error in the common case of non-circular errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular structure on error
3 participants