Skip to content

Commit

Permalink
usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT
Browse files Browse the repository at this point in the history
Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and
USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is
conditional upon USB && USB_SUPPORT, so that it can be freely selected
by platform Kconfig symbols in architecture code.

For example once the MIPS_GENERIC platform selects are fixed in commit
2e6522c ("MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN"), the MIPS
32r6_defconfig warns like so:

warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)

Fixes: 2e6522c ("MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN")
Signed-off-by: James Hogan <jhogan@kernel.org>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-mips@linux-mips.org
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Patchwork: https://patchwork.linux-mips.org/patch/18559/
  • Loading branch information
amalon committed Feb 15, 2018
1 parent 67a3ba2 commit ec89756
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 8 additions & 0 deletions drivers/usb/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ config USB_EHCI_BIG_ENDIAN_MMIO
config USB_EHCI_BIG_ENDIAN_DESC
bool

config USB_UHCI_BIG_ENDIAN_MMIO
bool
default y if SPARC_LEON

config USB_UHCI_BIG_ENDIAN_DESC
bool
default y if SPARC_LEON

menuconfig USB_SUPPORT
bool "USB support"
depends on HAS_IOMEM
Expand Down
8 changes: 0 additions & 8 deletions drivers/usb/host/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -633,14 +633,6 @@ config USB_UHCI_ASPEED
bool
default y if ARCH_ASPEED

config USB_UHCI_BIG_ENDIAN_MMIO
bool
default y if SPARC_LEON

config USB_UHCI_BIG_ENDIAN_DESC
bool
default y if SPARC_LEON

config USB_FHCI_HCD
tristate "Freescale QE USB Host Controller support"
depends on OF_GPIO && QE_GPIO && QUICC_ENGINE
Expand Down

0 comments on commit ec89756

Please sign in to comment.