-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update / fix french translation #459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the translation, before I merge this two comments:
- I'm unsure if you noticed, but the french translation is currently incomplete/outdated. First missed update was for version 4.1.0, what happened since when can be seen e.g. in https://github.com/lieser/dkim_verifier/issues?q=is%3Aissue+label%3Alocalization+is%3Aclosed. Adding the missing once is not required for this to be merged and it is up to you if you want to work on that too.
- In case you decide to also add the missing strings, let me know if you are interested in taking over the maintenance of the french translation.
@lieser Thanks for the notice! OK to take over the french translation! Thanks, |
753e8ba
to
144c5e9
Compare
@lieser I made change (and squash) to previous commit in order to have a global review of the translation + update FROM 4.1.0 to 5.5.0 version ;-) Bests regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for updating the translation and being whiling to maintain it. Your changes and the updating of translators LGTM,
I also updated https://github.com/lieser/dkim_verifier/wiki/Contribute#translations.
No description provided.