Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update / fix french translation #459

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

AnaelMobilia
Copy link
Contributor

No description provided.

lieser
lieser previously approved these changes Sep 10, 2024
Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the translation, before I merge this two comments:

  • I'm unsure if you noticed, but the french translation is currently incomplete/outdated. First missed update was for version 4.1.0, what happened since when can be seen e.g. in https://github.com/lieser/dkim_verifier/issues?q=is%3Aissue+label%3Alocalization+is%3Aclosed. Adding the missing once is not required for this to be merged and it is up to you if you want to work on that too.
  • In case you decide to also add the missing strings, let me know if you are interested in taking over the maintenance of the french translation.

@lieser lieser added this to the 5.5.0 milestone Sep 10, 2024
@AnaelMobilia
Copy link
Contributor Author

@lieser Thanks for the notice!
I will review all missing translation equally and send a full translation update.

OK to take over the french translation!

Thanks,
Anael

@AnaelMobilia
Copy link
Contributor Author

@lieser I made change (and squash) to previous commit in order to have a global review of the translation + update FROM 4.1.0 to 5.5.0 version ;-)
It took the liberty to update translator name on options.html, I can revert and/or change if it's not correct!

Bests regards,
Anael

Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating the translation and being whiling to maintain it. Your changes and the updating of translators LGTM,

I also updated https://github.com/lieser/dkim_verifier/wiki/Contribute#translations.

@lieser lieser merged commit e94385a into lieser:master Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants