Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon and rule for bayern.de (5.x) #447

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented May 30, 2024

No description provided.

Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where did you get the icon? If I look at bayern.de a different one is shown (https://www.bayern.de/favicon.ico)

@dodmi
Copy link
Contributor Author

dodmi commented Jun 3, 2024

Well, actually I didn't visit the website at all, but took an image of an Bavarian flag and cut out some part.
https://en.wikipedia.org/wiki/Flag_of_Bavaria
But there are two flags...
While
www.bayern.de uses https://www.bayern.de/favicon.ico
www.stmi.bayern.de uses https://www.stmi.bayern.de/odeon_assets/images/favicon/favicon.ico, which is similar to my image (and which probably most people associate with Bavaria).

Shall I change the image to https://www.bayern.de/favicon.ico instead?

@lieser
Copy link
Owner

lieser commented Jul 17, 2024

Shall I change the image to https://www.bayern.de/favicon.ico instead?

I would tend to say yes. I agree with you that the current image is probably easier associated with Bavaria, but so far we tended to always use the favicon of the associated website, in the hope they know best which Image they think represents them.

Note that separate images vor Subdomains are possible.

@dodmi
Copy link
Contributor Author

dodmi commented Jul 19, 2024

I've changed the icon. You're right, it's much easier to always use the icon from the domain.

@lieser lieser added this to the 5.5.0 milestone Jul 25, 2024
@lieser lieser merged commit a8e8c03 into lieser:master Jul 25, 2024
5 checks passed
@dodmi dodmi deleted the new-favicon-rules-5x-bayern branch July 25, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants