Important websites operating in Poland. #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for temporary 'hacks'
lieser
reviewed
Sep 17, 2023
|
Favicon is from e-mail service, which has this logo poczta.onet.pl.
Dnia 17 września 2023 15:57 Philippe Lieser napisał(a):
@lieser commented on this pull request.
On github.com data/favicon/intercity.pl.png :
Consider using the 32x32 version instead ( www.intercity.pl https://www.intercity.pl/favicon-32x32.png ), which I use most of the time as a compromise between size and visible details.
But also OK with leaving as is.
On github.com data/favicon/onet.pl.ico :
I currently see a different icon when visiting their website (just a yellow circle). Did they recently change their logo?
— Reply to this email directly, github.com view it on GitHub , or github.com unsubscribe . You are receiving this because you authored the thread. Message ID: <lieser/dkim_verifier/pull/393/review/1630084652 @ github . com>
|
Am I understanding it correctly that this is an e-mail provider, and users are getting e-mail addresses from the More details on the requirements for favicon are described here: |
Change onet.pl icon too.
New from pczta.onet.pl. Yellow dot with email symbol.
In my rush and distraction, I didn't read your note about not adding icons to email services. So I deleted them.
deleted email provider icons
deleted email provider icons
deleted email provider icons
deleted email provider icons
deleted email provider icons
deleted email provider icons
The new icons concern important utility services.
|
In my rush and distraction, I didn't read your note about not adding icons to email provider services. The new icons concern important utility services. |
lieser
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that users liked the favicon, so I added the websites that operate in Poland.