added datev.de #209
Merged
added datev.de #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieser
requested changes
Aug 25, 2020
There was a problem hiding this comment.
Thanks for the icon and rule.
There seems to be something wrong with the icon. If I try to view the icon in Firefox (https://raw.githubusercontent.com/lieser/dkim_verifier/8d48e0ede1eb4fbffd2bc127c6f8fd389ede4807/data/favicon/datev.de.ico) it only shows a Grey box. And it also didn't work inside the add-on in the quick test I did.
|
I wasnt's aware myself about the display issue but I can reproduce it. I informed our webmaster and wait for response. |
|
updated our branch to contain an favicon, that display more then a grey box |
lieser
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on behalf of DATEV this PR add our Logo