Skip to content

-Wstringop-overflow warning from gcc-14 #119

@sezero

Description

@sezero

In SDL_mixer, we are getting a -Wstringop-overflow warning from gcc-14:
libsdl-org/SDL_mixer#616

In file included from /tmp/SDL_mixer/src/codecs/minimp3/minimp3_ex.h:10,
                 from /tmp/SDL_mixer/src/codecs/music_minimp3.c:29:
In function 'L3_decode_scalefactors',
    inlined from 'L3_decode' at /tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:1245:9,
    inlined from 'mp3dec_decode_frame' at /tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:1773:17:
/home/ozzie/2/SDL_mixer/src/codecs/minimp3/minimp3.h:695:42: warning: writing 2 bytes into a region of size 1 [-Wstringop-overflow=]
  695 |             iscf[gr->n_long_sfb + i + 0] += gr->subblock_gain[0] << sh;
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/SDL_mixer/src/codecs/minimp3/minimp3.h: In function 'mp3dec_decode_frame':
/tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:662:26: note: at offset [39, 40] into destination object 'iscf' of size 40
  662 |     uint8_t scf_size[4], iscf[40];
      |                          ^~~~
In function 'L3_decode_scalefactors',
    inlined from 'L3_decode' at /tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:1245:9,
    inlined from 'mp3dec_decode_frame' at /tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:1773:17:
/tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:697:42: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
  697 |             iscf[gr->n_long_sfb + i + 2] += gr->subblock_gain[2] << sh;
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/SDL_mixer/src/codecs/minimp3/minimp3.h: In function 'mp3dec_decode_frame':
/tmp/SDL_mixer/src/codecs/minimp3/minimp3.h:662:26: note: at offset [41, 296] into destination object 'iscf' of size 40
  662 |     uint8_t scf_size[4], iscf[40];
      |                          ^~~~

Is it bogus, or should we take it seriously?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions