Fix MIPS n64 ELF relocation parsing - #1367
Open
plusls wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MIPS n64 (ELFCLASS64 + EM_MIPS) uses a non-standard on-disk
r_infolayout:r_info = r_sym[4] | r_ssym[1] | r_type3[1] | r_type2[1] | r_type[1]instead of the generic ELF64(sym << 32) | type. LIEF decoded all ELF64 relocations with the generic mask, which is wrong for MIPS n64:Little-endian:
r_symis in the low 32 bits, sor_info >> 32produces garbage symbol indices. This caused the AUTO dynsym count to explode (196 instead of 10) and relocation types to decode as UNKNOWN.Big-endian:
r_info & 0xffffffffdrags r_ssym/r_type3/r_type2 into the type field. Compound relocations (e.g. R_MIPS_GPREL16 with non-zero Type2/Type3) decode as garbage; simple ones match by accident.The MIPS n64 encode/decode is now isolated in an internal header
src/ELF/reloc_utils.hpp, keeping the public Relocation class format-agnostic (same pattern as the existing Android SLEB128 handling at the Parser/Builder boundary).The judgment key
arch == MIPS && class == ELF64matches binutilsABI_64_Pmacro. n32/o32 are ELFCLASS32 and handled by the Elf32 code path at compile time, so they cannot trigger the MIPS n64 branch.Non-MIPS architectures: zero change in decode/encode paths.