Skip to content

Feature/orc 428 ejector check events public keys#144

Merged
eddort merged 9 commits into
developfrom
feature/orc-428-ejector-check-events-public-keys
Jul 9, 2025
Merged

Feature/orc 428 ejector check events public keys#144
eddort merged 9 commits into
developfrom
feature/orc-428-ejector-check-events-public-keys

Conversation

@chasingrainbows
Copy link
Copy Markdown
Contributor

@chasingrainbows chasingrainbows commented Jul 3, 2025

Description

  1. Events pubkeys checking on CL added
  2. Add batching logic to src/services/job-processor/service.ts, to reduce CL requests amount
  3. VOTING_EVENTS_FRAME_BLOCKS added + pre-uploading of voting-based events
  4. Fixed minor bug when aragon voting have been ignored if easy track address is not set up

Related Issue/Task

  • Related task: orc-428

How Has This Been Tested?

Describe how you tested the changes:

  • Local tests (e.g., pytest)
  • Manual testing (describe steps)
  • Not tested (explain why)

Checklist

  • Documentation updated (if required)
  • New tests added (if applicable)

@chasingrainbows chasingrainbows changed the base branch from main to develop July 3, 2025 15:18
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch 3 times, most recently from c2af506 to 45feeb5 Compare July 3, 2025 19:34
@eddort
Copy link
Copy Markdown
Member

eddort commented Jul 4, 2025

Good job! I suggest moving the validator loading logic to a single place to unify the logic for checking public keys, metrics for withdrawn validators, remaining messages, and the isExiting check.

@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch 6 times, most recently from e542ca4 to 79212a1 Compare July 4, 2025 13:10
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch from 79212a1 to 2440fb2 Compare July 4, 2025 13:15
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch from 18bf2c0 to 4451aef Compare July 4, 2025 14:54
@chasingrainbows chasingrainbows requested review from F4ever and eddort July 4, 2025 16:15
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch from d19f5fa to 2470bd8 Compare July 4, 2025 16:50
Comment thread src/scripts/logs.ts
Comment thread src/services/consensus-api/cl.spec.ts
Comment thread src/services/consensus-api/service.ts Outdated
Comment thread src/services/exit-logs/fetcher.ts Outdated
Copy link
Copy Markdown
Member

@eddort eddort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a subtle issue in the way event proofs are calculated. The logic currently assumes that the entire relevant event window fits within toBlock - ORACLE_FRAME_BLOCKS, which holds for oracle submission proofs, but might not be valid for EasyTrack or Aragon voting proofs.

We should double-check the actual block range between vote creation and execution in those cases and verify that it consistently falls within the toBlock - ORACLE_FRAME_BLOCKS window. If not, we may need to adjust the logic or make the proof window configurable per use case.

@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch 2 times, most recently from 1a70e78 to 7596040 Compare July 7, 2025 15:28
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch 2 times, most recently from d1e43ed to ad1151a Compare July 7, 2025 17:37
@chasingrainbows chasingrainbows requested a review from eddort July 7, 2025 17:42
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch 3 times, most recently from 4cafd08 to ae1d5a9 Compare July 8, 2025 12:55
@chasingrainbows chasingrainbows force-pushed the feature/orc-428-ejector-check-events-public-keys branch from ae1d5a9 to ae140cb Compare July 8, 2025 13:00
Comment thread src/services/consensus-api/dto.ts
@eddort eddort merged commit f7cd4d5 into develop Jul 9, 2025
6 checks passed
@eddort eddort deleted the feature/orc-428-ejector-check-events-public-keys branch July 9, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants