Feature/orc 428 ejector check events public keys#144
Conversation
c2af506 to
45feeb5
Compare
|
Good job! I suggest moving the validator loading logic to a single place to unify the logic for checking public keys, metrics for withdrawn validators, remaining messages, and the isExiting check. |
e542ca4 to
79212a1
Compare
79212a1 to
2440fb2
Compare
18bf2c0 to
4451aef
Compare
d19f5fa to
2470bd8
Compare
eddort
left a comment
There was a problem hiding this comment.
There’s a subtle issue in the way event proofs are calculated. The logic currently assumes that the entire relevant event window fits within toBlock - ORACLE_FRAME_BLOCKS, which holds for oracle submission proofs, but might not be valid for EasyTrack or Aragon voting proofs.
We should double-check the actual block range between vote creation and execution in those cases and verify that it consistently falls within the toBlock - ORACLE_FRAME_BLOCKS window. If not, we may need to adjust the logic or make the proof window configurable per use case.
1a70e78 to
7596040
Compare
d1e43ed to
ad1151a
Compare
4cafd08 to
ae1d5a9
Compare
ae1d5a9 to
ae140cb
Compare
Description
Related Issue/Task
How Has This Been Tested?
Describe how you tested the changes:
pytest)Checklist