Feat: add defiwrapper sample state-mate config#64
Conversation
Change schema reference from main-schema.json to seed-schema.json to match the pattern used by other seed files in the repository. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ed config Remove inline comments that duplicate the value (e.g., `"0x..." # 0x...`). Also fix DEPLOY_FINISHED to be on a single line instead of using YAML line continuation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
TheDZhon
changed the title
|
|
This reverts commit 51625ce.
There was a problem hiding this comment.
Pull request overview
This PR adds configuration and tooling for the defiwrapper project on Ethereum mainnet, along with improvements to existing Lido V3 configs and CI workflow updates.
Changes:
- Added new defiwrapper mainnet seed and generated configuration files with Lido contract address annotations
- Introduced consolidated ABI bundles (compressed JSON) for both defiwrapper and lidov3 configs
- Added a helpful log message to guide users on consolidating ABI files
- Updated CI workflow to test Phase 2 Lido V3 configs instead of Phase 1
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/state-mate.ts |
Added informational log message showing how to consolidate ABI files after download |
configs/lidov3/mainnet/lidov3-et-post-vote-phase-2.yml |
Changed RPC URL from REMOTE_RPC_URL to MAINNET_REMOTE_RPC_URL |
configs/lidov3/mainnet/lidov3-core-post-phase-2.yaml |
Changed RPC URL from REMOTE_RPC_URL to MAINNET_REMOTE_RPC_URL |
configs/lidov3/mainnet/abis.json.gz |
New compressed ABI bundle for Lido V3 mainnet contracts |
configs/defiwrapper/mainnet.seed.yml |
New seed configuration defining deployed defiwrapper factory contracts |
configs/defiwrapper/mainnet.seed.generated.yml |
Generated configuration with contract checks, Lido addresses, and pool type definitions |
configs/defiwrapper/abis.json.gz |
New compressed ABI bundle for defiwrapper contracts |
.github/workflows/ci.yaml |
Updated to test Phase 2 configs instead of commented-out Phase 1 configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - &timelockFactory "0x15f2C9ea98e5564d25A46eE39D19704476998786" # TimelockFactory | ||
|
|
||
| l1: | ||
| rpcUrl: REMOTE_RPC_URL # https://ethereum-rpc.publicnode.com |
There was a problem hiding this comment.
Environment variable naming inconsistency detected. This file uses REMOTE_RPC_URL, but all other mainnet configs in this repository use the more specific MAINNET_REMOTE_RPC_URL pattern. This inconsistency could lead to configuration errors where different environment variables need to be set for different configs targeting the same network.
The convention in this codebase (as seen in configs/lidov3/mainnet/*.yaml, configs/safeharbor/mainnet.yml) is to use network-prefixed RPC URL environment variables (e.g., MAINNET_REMOTE_RPC_URL for mainnet, HOODI_REMOTE_RPC_URL for Holesky).
| include: | ||
| # Lido V3 configs - Mainnet (Phase 1) | ||
| - config: configs/lidov3/mainnet/lidov3-core-post-vote.yaml | ||
| # Lido V3 configs - Mainnet (Phase 2) | ||
| - config: configs/lidov3/mainnet/lidov3-core-post-phase-2.yaml | ||
| network: ethereum-mainnet | ||
| - config: configs/lidov3/mainnet/lidov3-et-post-vote.yml | ||
| - config: configs/lidov3/mainnet/lidov3-et-post-vote-phase-2.yml | ||
| network: ethereum-mainnet |
There was a problem hiding this comment.
The new defiwrapper configs are not included in the CI workflow test matrix. While the PR description mentions that testing was done manually with yarn start configs/defiwrapper/mainnet.seed.generated.yml, the CI workflow does not test these new configs automatically. This means future changes could break the defiwrapper configs without CI catching the issue.
Consider adding the defiwrapper config to the matrix to ensure it's tested on every CI run:
- config: configs/defiwrapper/mainnet.seed.generated.yml
network: ethereum-mainnet| - &timelockFactory "0x15f2C9ea98e5564d25A46eE39D19704476998786" # TimelockFactory | ||
|
|
||
| l1: | ||
| rpcUrl: REMOTE_RPC_URL # https://ethereum-rpc.publicnode.com |
There was a problem hiding this comment.
Environment variable naming inconsistency detected. The defiwrapper mainnet configs use REMOTE_RPC_URL, but all other mainnet configs in this repository use the more specific MAINNET_REMOTE_RPC_URL pattern. This inconsistency could lead to configuration errors where different environment variables need to be set for different configs targeting the same network.
The convention in this codebase (as seen in configs/lidov3/mainnet/*.yaml, configs/safeharbor/mainnet.yml) is to use network-prefixed RPC URL environment variables (e.g., MAINNET_REMOTE_RPC_URL for mainnet, HOODI_REMOTE_RPC_URL for Holesky).
3 participants
Summary
Testing