-
Notifications
You must be signed in to change notification settings - Fork 70
feat: oracle docs init reworks #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titanic work. 👍
But it misses some preface. I'd like to suggest adding some structural info about all oracle contracts architecture:
- how *Oracle, BaseOracle, and HashConsensus related to each other
- what is ReportProcessor
- which contract is responsible for what actions
- what is oracle daemon and oracle committee(with links)
- how they are reaching the consensus
- how they are managed
And it probably will be worth a Sam's look as finished.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of meaningful changes and insights about the Oracle-related contracts for Lido V2, thank you for putting everything together!
I'd suggest to provide more summaries, explainers and illustrative materials in general 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's roll it out 👍 |
No description provided.