Skip to content

feat: oracle docs init reworks #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Dec 11, 2023
Merged

feat: oracle docs init reworks #232

merged 18 commits into from
Dec 11, 2023

Conversation

loga4
Copy link
Contributor

@loga4 loga4 commented Jul 3, 2023

No description provided.

@loga4 loga4 mentioned this pull request Jun 30, 2023
33 tasks
@loga4 loga4 marked this pull request as ready for review August 14, 2023 11:16
@loga4 loga4 requested a review from a team as a code owner August 14, 2023 11:16
@loga4 loga4 requested review from TheDZhon and folkyatina August 14, 2023 11:17
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Titanic work. 👍

But it misses some preface. I'd like to suggest adding some structural info about all oracle contracts architecture:

  • how *Oracle, BaseOracle, and HashConsensus related to each other
  • what is ReportProcessor
  • which contract is responsible for what actions
  • what is oracle daemon and oracle committee(with links)
  • how they are reaching the consensus
  • how they are managed

And it probably will be worth a Sam's look as finished.

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of meaningful changes and insights about the Oracle-related contracts for Lido V2, thank you for putting everything together!

I'd suggest to provide more summaries, explainers and illustrative materials in general 🙏

@loga4 loga4 requested a review from a team as a code owner November 24, 2023 01:35
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon
Copy link
Contributor

Let's roll it out 👍

@TheDZhon TheDZhon merged commit 7ae873d into main Dec 11, 2023
@TheDZhon TheDZhon deleted the lido-v2/oracle-docs-reworks branch December 11, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants