Skip to content

feat: add staking router page #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 14, 2023
Merged

feat: add staking router page #230

merged 7 commits into from
Aug 14, 2023

Conversation

failingtwice
Copy link
Contributor

Added a one-pager on StakingRouter contract.

@failingtwice failingtwice requested a review from a team as a code owner June 30, 2023 08:53
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it concerning high-level descriptions and definitions 👍

🤔 However, could you please take a deeper look into mechanics and flows?
I mean, maybe something similar to the newly published Lido page.

❓ Also, maybe the API reference can be especially helpful since we aim for external developers to read these docs when developing new modules.

@TheDZhon TheDZhon mentioned this pull request Jul 8, 2023
33 tasks
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done the second pass ❤️

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's roll it out 🚀

@TheDZhon TheDZhon merged commit 91634b3 into main Aug 14, 2023
@TheDZhon TheDZhon deleted the staking-router-page branch August 14, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants