Consolidation request #1093
Merged
Consolidation request #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: 5b9d906 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
folkyatina
added
solidity
tamtamchik
reviewed
May 27, 2025
test/common/lib/triggerableWithdrawals/maxEffectiveBalanceIncreaser.test.ts
Outdated
Show resolved
Hide resolved
| const totalFee = BigInt(totalSourcePubkeysCount) * feeForRequest; | ||
| await consolidationRequestPredeployed.mock__setFee(feeForRequest); | ||
|
|
||
| await testEIP7251Mock( |
There was a problem hiding this comment.
Can we move expect statements into the test itself? It's difficult to dive deep just to verify assertions.
arwer13
reviewed
Jun 6, 2025
scripts/scratch/steps/0160-deploy-max-effective-balance-increaser.ts
Outdated
Show resolved
Hide resolved
scripts/scratch/steps/0160-deploy-max-effective-balance-increaser.ts
Outdated
Show resolved
Hide resolved
test/common/lib/triggerableWithdrawals/maxEffectiveBalanceIncreaser.test.ts
Outdated
Show resolved
Hide resolved
test/common/lib/triggerableWithdrawals/maxEffectiveBalanceIncreaser.test.ts
Outdated
Show resolved
Hide resolved
28 tasks
…reqeust triggers, fix tests, add new, rename contract and event
TheDZhon
reviewed
Jun 11, 2025
krogla
reviewed
Jun 17, 2025
| bytes calldata _targetPubkey, | ||
| uint256 _feePerRequest | ||
| ) private { | ||
| uint256 sourcePubkeysCount = _validateAndCountPubkeys(_sourcePubkeys); |
There was a problem hiding this comment.
it seems calling the_validateAndCountPubkeys again is redundant, since we already called it in the previous loop, and in this case it is enough to simply get the length without checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add contract that allows to request consolidations.
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7251.md
HOW
This PR introduces the addConsolidationRequests method for batching consolidation operations. The method is publicly callable, but two key constraints ensure secure and correct execution:
The method can be called by any address, but only requests with correct WC (as verified on the CL side) will have actual effect.
Dashboard.increaseRewardsAdjustment():Within addConsolidationRequests, the call to dashboard.increaseRewardsAdjustment() requires the caller (i.e., the contract) to have the NODE_OPERATOR_REWARDS_ADJUST_ROLE on the Dashboard contract.
Consolidation Process Overview
setRewardsAdjustmentto fix it.