Skip to content

fix(providers): honour Ollama private-network default during discovery - #775

Merged
Wibias merged 1 commit into
devfrom
fix/758-ollama-discovery-policy
Jul 31, 2026
Merged

Wibias merged 1 commit into
devfrom
fix/758-ollama-discovery-policy

Conversation

@Wibias

@Wibias Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #758

Honours Ollama private-network default during provider discovery.

Security

Destination-policy wiring only; registry defaults only; metadata/link-local still denied.

Test plan

  • CI green
  • Regression tests for discovery policy

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Wibias, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 09ab76c6-8eef-4937-a65f-a0869b8e7bc5

📥 Commits

Reviewing files that changed from the base of the PR and between be177ea and 51f9546.

📒 Files selected for processing (3)
  • src/lib/destination-policy.ts
  • src/lib/provider-outbound.ts
  • tests/provider-outbound.test.ts

Comment @coderabbitai help to get the list of available commands.

@Wibias

Wibias commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

[shipping-github] Merge-ready

  • \mergeStateStatus: CLEAN (duplicate workflow run reconciled; both \windows-latest\ checks success on HEAD \51f95463)
  • Full cross-platform matrix + enforce-target + react-doctor green
  • Earlier windows failures were runner flakes (\�xecuteArchivedCleanup\ timeouts / Bun panic), not branch regressions

@Wibias

Wibias commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Verdict: approve-comment

@Wibias
Wibias merged commit c3be57f into dev Jul 31, 2026
34 of 37 checks passed
@Wibias
Wibias deleted the fix/758-ollama-discovery-policy branch July 31, 2026 04:02
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
…ery-policy

fix(providers): honour Ollama private-network default during discovery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant