Repository navigation
docs-site: mobile homepage polish, persistent GitHub link and star count - #6753
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe changes add build-time GitHub star counts to the documentation header and landing page, adjust homepage layout and touch targets, and document recovery, integration, release publication, and homepage verification procedures for version 2.81.0. ChangesRecovery and homepage
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant Header as Header.astro
participant Stars as github-stars.ts
participant GitHub as GitHub API
Header->>Stars: getStarCount()
Stars->>GitHub: Request repository star count
GitHub-->>Stars: Response with stargazers_count
Stars-->>Header: Count or null
Header->>Stars: formatStarCount(count)
Merge Risk: ⚪ Minimal · up to The homepage changes appear mergeable after the normal exact-head checks; the GitHub links remain usable when a star count is unavailable. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The homepage now keeps a GitHub link visible in the fixed header on phones as well as desktop, shows a compact star count when available, and adds a localized GitHub link near the lower documentation map. Mobile command examples wrap, touch targets are larger, and media dimensions reserve space during loading. Existing desktop composition and all eight locales are preserved.
Star counts are fetched once at build time from GitHub's public repository API, without credentials, with a five-second timeout. Offline builds, rate limits and malformed responses render a usable link without a number. Counts remain static until the next deployment. No client polling or third-party badge service was added.
Also records the reviewed recovery plan for the owner-authorized 2.81.0 release train. The plan does not claim release completion.
Verification
cd docs-site && bun install --frozen-lockfile && bun run build: 569 pages, 79,090 internal links, successful build. The normal request hit the API fallback. A separate scratch build with a synthetic17092API response verified the17klayout; the fixture is not shipped.bun testover all 24 test files referencing docs-site: 573 pass, 0 fail.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --checkpassed.5c5ec574f0d407a8535b107c7957030d4113c7d2, all four implementation files, with no actionable findings. Separate architect reflection and independent audit approved the recovery roadmap.lane=allrun cover broader execution. Hosted results will be checked against this exact PR head before merge.Screenshots are stored only on the separate pr-assets branch. The after-count images use the explicitly synthetic 17,092-star response. Before images have DPR 2 and after images DPR 1; CSS viewport sizes match.
Scrolled Korean mobile · API failure fallback
Maintainer integration evidence
The owner explicitly authorized this homepage improvement, independent inherited review, merge and release. I am choosing the dev-only maintainer-integration path under MAINTAINERS.md, separately from technical approval. Reviewer Jason approved exact head
5c5ec574f0d407a8535b107c7957030d4113c7d2with no actionable findings and inspected the saved count/fallback screenshots and reports. Cross-platform CI 37750991759, pull_request event, attempt 1, completed successfully at that head: docs site build, privacy gate and aggregate CI passed. Runtime matrix jobs were correctly excluded by docs-only path filters and are not claimed as tested by this run. The focused local checks above and the later integrated lane=all run provide their separate evidence.git merge-tree --write-tree HEAD origin/devcomposed cleanly against the landed picker cleanup.Checklist
Summary by CodeRabbit