Repository navigation
test(oauth): count the web-search sidecar rotation site - #6717
Merged
Merged
Conversation
Owner
Author
|
Maintainer integration into dev (dev-only maintainer integration): fix-forward for the red final CI 37636581013 on f9b96b7. Exact head 778d625; test-only count update verified locally (generic-oauth-failover 67/0, tests/oauth 671/0). A fresh lane=all Cross-platform CI runs on the dev tip after merge. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The final dev Cross-platform CI (run 37636581013, dev
f9b96b733c) failed intests/oauth/generic-oauth-failover.test.ts>sidecar on429 wiring > every rotation site applies the credential through the one shared helper: expected 9 rotation sites, received 10. #6710 added a tenth site, the web-search sidecar's structuredVALIDATION_REQUIREDrotation, and it goes throughapplyFailoverSnapshotlike every other site. The test's real invariants still hold (snapshot sites == helper uses, exactly one bearer write inside the helper); only the pinned count was stale. This updates the count to 10 and names the new site in the comment.Verification
bun test ./tests/oauth/generic-oauth-failover.test.ts: 67 pass, 0 fail.bun test ./tests/oauth: 671 pass;./tests/web-search: 362 pass;./tests/server: 3870 pass../tests/claude-integrationand./tests/codex-integrationin one local process showed cross-file contamination failures; each failing file passes alone (claude-messages-endpoint 54/0, model-cache 5/0, codex-management-convergence 80/0, codex-main-token-invalidated 9/0, token-guardian 18/0), and the hosted run onf9b96b733cpassed those suites.oauth-login-cli-live-updateon Windows 9/9, is anEPERMwhile removing a temp directory in teardown, the known Windows runner flake.workflow_dispatchCross-platform CI runs on the dev tip after merge.Checklist
dev.