Skip to content

test(oauth): count the web-search sidecar rotation site - #6717

Merged
lidge-jun merged 1 commit into
devfrom
codex/fix-rotation-site-count
Oct 7, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/fix-rotation-site-count

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

The final dev Cross-platform CI (run 37636581013, dev f9b96b733c) failed in tests/oauth/generic-oauth-failover.test.ts > sidecar on429 wiring > every rotation site applies the credential through the one shared helper: expected 9 rotation sites, received 10. #6710 added a tenth site, the web-search sidecar's structured VALIDATION_REQUIRED rotation, and it goes through applyFailoverSnapshot like every other site. The test's real invariants still hold (snapshot sites == helper uses, exactly one bearer write inside the helper); only the pinned count was stale. This updates the count to 10 and names the new site in the comment.

Verification

  • bun test ./tests/oauth/generic-oauth-failover.test.ts: 67 pass, 0 fail.
  • bun test ./tests/oauth: 671 pass; ./tests/web-search: 362 pass; ./tests/server: 3870 pass.
  • Directory runs of ./tests/claude-integration and ./tests/codex-integration in one local process showed cross-file contamination failures; each failing file passes alone (claude-messages-endpoint 54/0, model-cache 5/0, codex-management-convergence 80/0, codex-main-token-invalidated 9/0, token-guardian 18/0), and the hosted run on f9b96b733c passed those suites.
  • The other failure in that run, oauth-login-cli-live-update on Windows 9/9, is an EPERM while removing a temp directory in teardown, the known Windows runner flake.
  • Full local suite not run; a fresh workflow_dispatch Cross-platform CI runs on the dev tip after merge.

Checklist

  • Test-only change, no gui/ paths, no behavior change.
  • Targets dev.

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 7, 2026 15:03
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (dev-only maintainer integration): fix-forward for the red final CI 37636581013 on f9b96b7. Exact head 778d625; test-only count update verified locally (generic-oauth-failover 67/0, tests/oauth 671/0). A fresh lane=all Cross-platform CI runs on the dev tip after merge.

@lidge-jun
lidge-jun merged commit bbab02a into dev Oct 7, 2026
@lidge-jun
lidge-jun deleted the codex/fix-rotation-site-count branch October 7, 2026 15:03
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T15:06:05.881057Z 778d625 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Oct 7, 2026
@lidge-jun lidge-jun mentioned this pull request Oct 8, 2026
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant