Repository navigation
feat(cli): add live provider management and safe editor apply - #6528
Merged
Merged
Conversation
…i-parity-foundation # Conflicts: # scripts/test-layout/layout.json # tests/fixtures/test-layout-expected.json
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (113)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
lidge-jun
marked this pull request as ready for review
October 3, 2026 18:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7209223a36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 3, 2026
Dev now refuses catalog refreshes for a foreign or unknown Codex home owner and for unbacked routed removals, keeping the catalog unchanged and returning a recovery warning. provider add --sync already exited nonzero on the refused outcome but dropped the warning; it now forwards the owner's fixed, path-free guidance to human output and sync.warning in JSON.
…ation Resolve test-layout registry conflict as a union: both sides only added entries.
…ation Resolve test-layout registry conflict as a union: both sides only added entries.
…ation Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
…iders Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
…ation Resolve test-layout registry conflict as a union: both sides only added entries.
…ation Resolve shared-file conflicts: test-layout registries as key unions; structure/runtime.md ownership rows taken from whichever side changed each row.
…ation Resolve shared-file conflicts: test-layout registries as key unions; structure/runtime.md ownership rows taken from whichever side changed each row.
Owner
Author
|
Maintainer integration (lidge-jun, dev only) — 2026-10-04 landing train, lane L1 stack.
|
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider add --sync --jsonto perform the requested sync and distinguish successful config injection from catalog convergence. Incomplete model synchronization preservesneedsSync, safe structured evidence and a nonzero exit; unchanged current catalogs remain successful.codex/cli-parity-foundation). This PR adds the provider-management task slice; subsequent layers cover models/routing and remaining GUI operations. Seedevlog/_plan/261003_cli_gui_parity/032_provider_verification.md.Verification
Stack refresh onto dev (lane L1, 2026-10-04; re-refreshed 2026-10-05 onto dev
df61d03ecc), head697cc9ec332dd7f4ab5618ae045411a3a7cba630. Merged the refreshed parent (dev584b92a53c). Reconciled with dev's catalog-owner safeguards (#6529 follow-ups80940782c5,3ee6137675): when the catalog owner refuses a refresh (foreign/unknown Codex home owner or unbacked routed removal)provider add --syncalready exited 1 but dropped dev's recovery warning; commit922485b4dcnow projects only the owner's fixed, path-free guidance to human output andsync.warningin JSON (nine new refusal cases intests/cli/cli-provider-sync-result.test.ts; provider sync/result/lifecycle and dev's codex sync, catalog-intent, routed-removal, home-owner and convergence test files passed). Local checks at this head:bun scripts/file-size-ratchet.ts(pass; test-layout fixture now well under the 2000-line threshold after #6583),tests/test-layout.test.ts+tests/test-layout-tooling.test.ts(pass),bun run typecheck(pass),bun run structure:check(pass); on the stack top additionallyskill:surface:check,privacy:scanand the skill/capability/ratchet test files (all pass). The full local suite was intentionally not run per maintainer instruction; broad and platform coverage is left to exact-head hosted CI: Cross-platform CI run 37217207354 (success at this head). Earlier-head CI results below are historical. Later dev moves (#6576, #6578, #6405, #6486, #6512, #6572, #6585, #6586, #6564) were merged in the same way; test-layout fixture conflicts were resolved as key unions, and this layer now packs only its own new entries inscripts/test-layout/layout.jsonfour per line (JSON content unchanged; the file stays clear of the 2000-line threshold for unbaselined files once the stack lands).Current-head hosted CI passed at
991110ddafaf0c28aaa3d9ae420da123323c427d: run 37159734892,pull_requestevent, attempt 1; all four test shards and aggregatecisucceeded. This manual layer targetscodex/cli-parity-foundationand contains its refreshed parent plus pinned dev0818ea1812a028e1c14cd0b0511b44863407bc52. Earlier-head results below remain historical. Optional platform jobs skipped by scope are not claimed as executed. Correct remote and independent review findings were repaired and propagated upward; no PR was merged.Independent plan, functional code and security code reviews passed after repairs. Focused tests exercise exact CLI requests, strict parsing, safe receipts, real isolated provider-editor CAS/persistence and real sync backend partial outcomes.
Actual CLI QA passed 17 scenarios against an injected management fixture with sockets forbidden and isolated application homes: snapshot/file/stdin apply, stale conflict, add/default/pacing/delete, confirmation and malformed-input refusals, stopped target and saved-but-pending output. Temporary homes were removed; user configuration and services were untouched.
Final source-bound gate at
604086504b5a84541e05679034f884717a944615: 797 tests passed, 0 failed across 26 files; typecheck, structure, generated skill, privacy and whitespace passed. Docs built 561 pages and checked 77,960 internal links. The final head also has the successful hosted CI noted in the follow-up below.The full local suite was not repeated because of its resource cost across concurrent worktrees. Focused relevant parser, indirect source-oracle, real server/backend and structural tests were used; broad and platform coverage is left to exact-head hosted CI. No paid provider request, live credential, release or deployment was exercised.
Hosted-CI follow-up at
7209223a36: corrected the legacy help example list and provider PATCH test fixture after the first run failed; 115 focused tests and typecheck passed. Production behavior is unchanged by that follow-up; Fresh exact-head hosted CI passed all four test shards and the required checks. Skipped platform/path jobs were not executed and are not counted as passes.Checklist