Repository navigation
Conversation
Map permission and subscription gates to permission_denied / subscription_required so Logs Details match Forbidden, not a bad key.
Owner
|
Thanks for the fix — the direction (clearer 403 labels) was right, and we've landed it on
Full suite green (2,929 tests). Closing this PR in favor of the dev-landed commits; the change will ship with the next release. |
8 tasks
kartikkabadi
added a commit
to kartikkabadi/opencodex
that referenced
this pull request
Aug 14, 2026
Port codex-router PR lidge-jun#145: a 200 that completes with no output text and no tool call is a failure the client cannot see (it silently records the turn as done). Hold pre-content adapter events, suppress the terminal of an empty turn, retry the IDENTICAL request once, and surface empty_completion_retry_failed when the retry is also empty or fails upstream. Usage is merged across both attempts so the request log meters the whole turn. Kill switch: OCX_EMPTY_COMPLETION_RETRY=0 restores the previous behavior. Compaction turns and combo attempts are excluded.
yansigit
referenced
this pull request
in yansigit/opencodex
Aug 15, 2026
Port codex-router PR #145: a 200 that completes with no output text and no tool call is a failure the client cannot see (it silently records the turn as done). Hold pre-content adapter events, suppress the terminal of an empty turn, retry the IDENTICAL request once, and surface empty_completion_retry_failed when the retry is also empty or fails upstream. Usage is merged across both attempts so the request log meters the whole turn. Kill switch: OCX_EMPTY_COMPLETION_RETRY=0 restores the previous behavior. Compaction turns and combo attempts are excluded.
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
Apply the contributor-owned 403 permission/subscription labeling checkpoint unchanged before the separately attributed maintainer repairs. Source: community PR lidge-jun#145 Source-head: fa4ca86
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
Repair auth/permission precedence, scope subscription labels to permission contexts, and cover the real Ollama HTTP body plus bare-403 behavior. Source: community PR lidge-jun#145 Source-head: fa4ca86 Co-authored-by: Wibias <37517432+Wibias@users.noreply.github.com>
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
Port codex-router PR lidge-jun#145: a 200 that completes with no output text and no tool call is a failure the client cannot see (it silently records the turn as done). Hold pre-content adapter events, suppress the terminal of an empty turn, retry the IDENTICAL request once, and surface empty_completion_retry_failed when the retry is also empty or fails upstream. Usage is merged across both attempts so the request log meters the whole turn. Kill switch: OCX_EMPTY_COMPLETION_RETRY=0 restores the previous behavior. Compaction turns and combo attempts are excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
invalid_api_key.permission_denied(default 403) andsubscription_requiredwhen the upstream text mentions subscription/upgrade.Test plan
bun test tests/error-fidelity.test.ts tests/errors-adapter-failure.test.ts tests/request-log.test.tspermission_deniedorsubscription_required, notinvalid_api_keyinvalid_api_key