Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add offline games ("Over the board") #924

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

tom-anders
Copy link
Contributor

@tom-anders tom-anders commented Aug 12, 2024

Closes #287

Design is pretty close to the old lichess app and the basic functionality is implemented. Some minor features from the old app are missing and could be added in follow-up PRs:

  • Different clock modes (Bronstein delay, handicap etc.)
  • Share game as PGN
  • Import game on lichess
  • Claim threefold repitition
  • Symmetric pieces
  • Flip pieces after move

@tom-anders tom-anders marked this pull request as draft August 12, 2024 12:04
@tom-anders tom-anders force-pushed the overTheBoard branch 8 times, most recently from deb9522 to 17e3d2f Compare August 20, 2024 20:27
@tom-anders tom-anders marked this pull request as ready for review August 20, 2024 20:32
@tom-anders
Copy link
Contributor Author

Demonstration video:

over_the_board.webm

@EmmetSchuler
Copy link

Everything looks really good so far!
Just some quick feedback that I thought might be useful:

I think there should be an option to pick the piece color for the main player, so that you don't have to rotate the phone and give all the menus / options to the secondary player.

There's an option in the original otb mode that I find particularly useful, where it flips all pieces and info for the person whose turn it is to move. Would that be something to consider?

Having the option to add +15 seconds of time to your opponent's clock would be nice to have too.

@tom-anders tom-anders force-pushed the overTheBoard branch 3 times, most recently from a791a1b to 3c70d62 Compare August 21, 2024 21:05
@tom-anders
Copy link
Contributor Author

Thanks!

I think there should be an option to pick the piece color for the main player, so that you don't have to rotate the phone and give all the menus / options to the secondary player.

Sounds useful, I'll add it to the settings as well

There's an option in the original otb mode that I find particularly useful, where it flips all pieces and info for the person whose turn it is to move. Would that be something to consider?

Yeah, looks like it needs to be implemented in flutter-chessground first, I opened a PR 👍

Having the option to add +15 seconds of time to your opponent's clock would be nice to have too.

Also a useful feature, but I'm not sure where we would put this button - Probably in the bottom bar? any other ideas?

@tom-anders
Copy link
Contributor Author

Rebased against main and adapted to chessground API changes.

Some updates on the comments above:

Thanks!

I think there should be an option to pick the piece color for the main player, so that you don't have to rotate the phone and give all the menus / options to the secondary player.

Sounds useful, I'll add it to the settings as well

Added the usual "flip board" button in the bottom bar for this.

There's an option in the original otb mode that I find particularly useful, where it flips all pieces and info for the person whose turn it is to move. Would that be something to consider?

Done 👍

Having the option to add +15 seconds of time to your opponent's clock would be nice to have too.

Since this is now planned for normal/online games as well (#936), let's wait for that to be done and then add it here as well

Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work! Thank you.

@veloce veloce merged commit bd8e848 into lichess-org:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Offline play
3 participants