Add remaining missing mobile translations

[tom-anders]

This solves #753

I didn't add any translation for the Puzzle Storm description, since the string is copied from lila (which does not have a translation yet either)

[veloce]

Thanks.

There is also the Join a game from the custom game creation screen that is missing.

[tom-anders]

Thanks.

There is also the Join a game from the custom game creation screen that is missing.

Ah, we already have a string for that actually, apparently I just forgot to use it

[veloce]

@tom-anders can you solve the conflicts please?

[tom-anders]

@veloce This should probably be fine for most languages, but I'm sure there are some languages where "Hello, %s" does not make any sense, we might want to revisit this at some point

[veloce]

@tom-anders that is because we use the UserFullNameWidget.

Now that I think of it we should make it right from the start and have a parameterised message such as helloX : Hello, <name>.

We can adapt the HelloWidget later to show the flair for instance.

[tom-anders]

Ok, so the string is now 'Hello %s' and I added a special case in the translation generation, making sure that the %s is not converted to a function parameter. This way, we can instead split the (localized) string at '%s' and put the UserNameWidget between the two resulting parts.

[tom-anders]

@tom-anders can you solve the conflicts please?

Done 👍

I didn't see the Hello, X thing.

[veloce]

Not sure about this. Is the greetingParts.length always 2?

[tom-anders]

Yes, according to the flutter docs:

A non-empty match at the start or end of the string, or after another match, is not treated specially, and will introduce empty substrings in the result

So we'll always get 2 here, as long as '%s' is somewhere in the string, including start and end. (If not, it's a translation issue, the comment says to always include the %s)

[veloce]

I think it's a common use case (inclusion of a widget instead of string in a translation) so it should be factored out in a utility function.

And this function should have unit tests.

[tom-anders]

Ah yes good point, will do 👍

[tom-anders]

Ok, added a utility function

IList<Widget> replaceL10nPlaceholderWithWidget<T extends Widget>(
  String Function(String) l10nWithReplacement,
  T widget, {
  TextStyle? textStyle,
})

To avoid empty text widgets, this now also catches the case where the placeholder is at start the start or end and only adds one instead of two Text Widgets in that case

[veloce]

One remaining change about the signature of the utility function and we're good I think :)