Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile preferences screen when offline #704

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix profile preferences screen when offline #704

merged 1 commit into from
May 19, 2024

Conversation

amanxnanda
Copy link
Contributor

@amanxnanda amanxnanda commented May 19, 2024 •
edited
Loading

Fixes #691

@amanxnanda
Copy link
Contributor Author

@veloce can you please review this one?

@amanxnanda amanxnanda changed the title Fix account prefereneces error & retry Fix profile preferences screen when offline May 19, 2024
veloce
veloce approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@veloce veloce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (No need to ping me when submitting a pr btw)

@veloce veloce merged commit 5b6c2b1 into lichess-org:main May 19, 2024
1 check passed
@amanxnanda
Copy link
Contributor Author

amanxnanda commented May 19, 2024 •
edited
Loading

Thanks! (No need to ping me when submitting a pr btw)

Got it!
I couldn't add you as a reviewer because of a lack of permissions, that's why tagged.

@amanxnanda amanxnanda deleted the fix/account-preferences-error branch May 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veloce veloce veloce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix profile preferences screen when offline
2 participants
@amanxnanda @veloce