Fix for android "Remove animations" system setting not reflected by board settings > piece animation

[Sriram-L]

Fixes #2534

Fix description:
The fix basically fetches current value of "Remove animations" in Android, and the board settings UI refreshes so that after fetching the value from system settings, the toggle option will be disabled if the system animation is disabled, and enabled when system animation is enabled.

Attaching a recording of how the fix works.

piece_animation_setting.mp4

[tom-anders]

Thanks for the contribution!

However, I think this does not fix the issue in #2534. The reporter of this issue suggested that the piece animation toggle should work, regardless of whether animations are disabled on the system level or not.

[Sriram-L]

Thanks for the contribution!

However, I think this does not fix the issue in #2534. The reporter of this issue suggested that the piece animation toggle should work, regardless of whether animations are disabled on the system level or not.

Thanks for the reply!

But I checked when "Remove animations" is enabled, piece animations do not work no matter what. So how can we satisfy this requirement regardless of this setting?

[tom-anders]

Thanks for the contribution!
However, I think this does not fix the issue in #2534. The reporter of this issue suggested that the piece animation toggle should work, regardless of whether animations are disabled on the system level or not.

Thanks for the reply!

But I checked when "Remove animations" is enabled, piece animations do not work no matter what. So how can we satisfy this requirement regardless of this setting?

No idea - you'd have to do some research if flutter somehow allows overriding/ignoring the system's "remove animations" setting.

[veloce]

Do we really want to follow the android system "Remove animations" toggle for our piece animations? I don't think this is a good idea, it looks like 2 very different things to me.

[tom-anders]

Do we really want to follow the android system "Remove animations" toggle for our piece animations? I don't think this is a good idea, it looks like 2 very different things to me.

Yes, the problem is that currently we do follow this toggle in the android system (see the original issue): When "remove animations" is active in the Android systems, them piece animations currently are disabled as well. I assume that flutter somehow internally notices this and overrides the animation duration. The OP in the original issue argues that piece animations should ignore that setting. So we'd need to find some way to stop flutter respecting that system toggle.

[veloce]

I had no idea that Flutter did this. But it makes sense in a way, this can be used to save battery for instance.

Not sure we can do sth about it, it needs an investigation.