Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an evaluation bar to the board #52

Closed
wants to merge 1 commit into from

Conversation

julien4215
Copy link

Screenshot_1724856900

@veloce
Copy link
Collaborator

veloce commented Aug 29, 2024

It looks very nice, but I don't think this ought to be part of chessground.

Instead it should be a wrapper widget in the application BoardWithEval or sth like that. I don't think the implementation would be harder if it is external, would it?

@julien4215
Copy link
Author

julien4215 commented Aug 29, 2024

I added it in chessground because of the borderRadius and boxShadow. Since the eval bar is next to the board, it should be applied to both and I can't do that outside of chessground.

@veloce
Copy link
Collaborator

veloce commented Aug 30, 2024

I think you can. You need to create another widget that:

  • set only the radius to the left side of the board
  • set only the radius to the right side of the eval bar
  • put board and eval bar side by side

With the board shadow it is more complex, so let's just remove any shadow for that combo widget.

@julien4215 julien4215 closed this by deleting the head repository Aug 31, 2024
@julien4215
Copy link
Author

Done in the PR lichess-org/mobile#944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants