Skip to content

rank moves without sorting the entire list#26

Merged
niklasf merged 3 commits intomasterfrom
rank-without-sort
Nov 12, 2025
Merged

rank moves without sorting the entire list#26
niklasf merged 3 commits intomasterfrom
rank-without-sort

Conversation

@niklasf
Copy link
Member

@niklasf niklasf commented Nov 11, 2025

Before:

[info] Benchmark               Mode  Cnt     Score    Error  Units
[info] HuffmanPgnBench.encode  avgt  120  7181.847 ± 48.616  us/op

After:

[info] HuffmanPgnBench.encode  avgt  120  3126.608 ± 19.164  us/op

Before:

    [info] Benchmark               Mode  Cnt     Score    Error  Units
    [info] HuffmanPgnBench.encode  avgt  120  7181.847 ± 48.616  us/op

After:

    [info] HuffmanPgnBench.encode  avgt  120  3126.608 ± 19.164  us/op
@niklasf
Copy link
Member Author

niklasf commented Nov 11, 2025

The full sort in encoding is even more useless ... intending to land this before #25, where there's more things to try, and to rename selectNth(n: Int) to something like selectRank(rank: Int).

@niklasf niklasf requested a review from isaacl November 11, 2025 21:19
@niklasf niklasf removed the request for review from isaacl November 12, 2025 17:59
@niklasf niklasf merged commit c9b0852 into master Nov 12, 2025
2 checks passed
@niklasf niklasf deleted the rank-without-sort branch November 12, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants