Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add kafka to requirements #304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add kafka to requirements #304

wants to merge 1 commit into from

Conversation

ciprian-cgr
Copy link
Contributor

No description provided.

@meysam81
Copy link
Contributor

@ciprian-cgr
You don't need this. This is already been defined here, i.e. you can simply pip install licenseware[kafka] to have the same outcome.

@meysam81
Copy link
Contributor

On second thoughts, I think adding it to the "required" dependencies is better since a normal pip install licenseware doesn't work right now.

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adrian-mih adrian-mih removed the request for review from ClimenteA January 31, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciprian-cgr @meysam81