-
Notifications
You must be signed in to change notification settings - Fork 134
Fix compatibility with bundler 4.x #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@mnin A bunch of tests failing here. Should also add a new CI configuration for testing this on Bundler 4. |
|
@MikeMcQuaid yes, thanks, not done yet with this PR. |
|
@mnin thanks for your progress on this - looks like it's taken some effort to address! 🙏 |
.ruby-version
Outdated
| @@ -1 +1 @@ | |||
| 3.1.7 | |||
| 3.2.10 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can bump this to 4.0.1 if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I didn't want to change everything right away due to incompatibility with e.g. nokogiri and Ruby 3.1, among other things.
I was already on Ruby 4 with the PR.
I will implement it.
We want to fix the compatibility with bundler 4.x here because we got this exception (for e.g.
pgorgoogle-protobuforgrpcgems.