Skip to content

Conversation

@mnin
Copy link

@mnin mnin commented Jan 15, 2026

We want to fix the compatibility with bundler 4.x here because we got this exception (for e.g. pg or google-protobuf or grpc gems.

Caching dependency records for project
  bundler
  * 0 bundler dependencies
bundler: failed to load command: licensed (/home/runner/work/project/project/vendor/bundle/ruby/4.0.0/bin/licensed)
/opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/materialization.rb:32:in 'Bundler::Materialization#dependencies': undefined method 'runtime_dependencies' for an instance of Licensed::Bundler::MissingSpecification (NoMethodError)

      (materialized_spec || specs.first).runtime_dependencies.map {|d| [d, platform] }
                                        ^^^^^^^^^^^^^^^^^^^^^
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/spec_set.rb:260:in 'block in Bundler::SpecSet#materialize_dependencies'
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/spec_set.rb:246:in 'Kernel#loop'
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/spec_set.rb:246:in 'Bundler::SpecSet#materialize_dependencies'
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/spec_set.rb:126:in 'Bundler::SpecSet#materialize'
	from /home/runner/work/project/project/vendor/bundle/ruby/4.0.0/bundler/gems/licensed-c4a2115b42ee/lib/licensed/sources/bundler/definition.rb:17:in 'Licensed::Bundler::DefinitionExtensions#specs'
	from /home/runner/work/project/project/vendor/bundle/ruby/4.0.0/bundler/gems/licensed-c4a2115b42ee/lib/licensed/sources/bundler.rb:54:in 'block in Licensed::Sources::Bundler#enumerate_dependencies'
	from /home/runner/work/project/project/vendor/bundle/ruby/4.0.0/bundler/gems/licensed-c4a2115b42ee/lib/licensed/sources/bundler.rb:110:in 'block in Licensed::Sources::Bundler#with_application_environment'
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/ui/shell.rb:177:in 'Bundler::UI::Shell#with_level'
	from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/bundler-4.0.3/lib/bundler/ui/shell.rb:122:in 'Bundler::UI::Shell#silence'
	from /home/runner/work/project/project/vendor/bundle/ruby/4.0.0/bundler/gems/licensed-c4a2115b42ee/lib/licensed/sources/bundler.rb:98:in 'Licensed::Sources::Bundler#with_application_environment'

@MikeMcQuaid
Copy link
Contributor

@mnin A bunch of tests failing here. Should also add a new CI configuration for testing this on Bundler 4.

@mnin
Copy link
Author

mnin commented Jan 15, 2026

@MikeMcQuaid yes, thanks, not done yet with this PR.

@mnin mnin marked this pull request as draft January 15, 2026 21:03
@dgmstuart
Copy link

@mnin thanks for your progress on this - looks like it's taken some effort to address! 🙏

.ruby-version Outdated
@@ -1 +1 @@
3.1.7
3.2.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can bump this to 4.0.1 if desired.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I didn't want to change everything right away due to incompatibility with e.g. nokogiri and Ruby 3.1, among other things.

I was already on Ruby 4 with the PR.

I will implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants