Add hotkey for help about advanced hotkeys (bsc#1010039) #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwh42
force-pushed
the
master
branch
2 times, most recently
from
0c66741 to
dd63c5b
Compare
shundhammer
reviewed
Nov 21, 2016
src/NCDialog.cc
Outdated
|
|
||
| break; | ||
|
|
||
| case KEY_F( 13 ): |
Contributor
There was a problem hiding this comment.
Please add a comment that says that this is the equivalent to Shift-F1 for certain $TERM types (linux? xterm?).
Contributor
|
Besides the missing comment above, LGTM. |
Contributor
Author
|
Comment is there, now. |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to use Shift-F1 as an universal hotkey-helper-hotkey in ncurses. It depends on the terminal whether it reaches the application, or not.
So I added two hotkeys:
I chose Ctrl-D as a prefix, because most of the other advanced hotkeys also do so.